First version of stack deployment tutorial by aanand · Pull Request #685 · docker/docs

aanand · 2016-11-22T16:43:39Z

To try this tutorial out, you need a 1.13 daemon, a 1.13 client and a master build of Compose.

dnephin

Looks great, few comments about the commands and typo

dnephin · 2016-11-22T16:56:15Z

engine/swarm/stack-deploy.md

+---
+
+When running Docker Engine in swarm mode, you can use `docker stack deploy`
+(or just `docker deploy`) to deploy a complete application stack to the swarm.


We're planning on keeping docker deploy experimental in 1.13 so that we can change it later if we need to. We might want to avoid calling it out here since it won't be available to everyone like docker stack deploy.

dnephin · 2016-11-22T16:56:40Z

engine/swarm/stack-deploy.md

+The `deploy` command accepts a stack description in the form of a [Compose
+file](/compose/compose-file.md).
+
+The `docker deploy` command supports any Compose file of version "3.0" or


docker stack deploy

dnephin · 2016-11-22T16:59:25Z

engine/swarm/stack-deploy.md

+    Compose doesn't take advantage of swarm mode, and deploys everything to a
+    single node. You can safely ignore this.
+
+    <!-- TODO: this warning needs to be updated for `docker deploy` -->


I think this is done: docker/compose#4170 (needs merged)

Unless you mean something else

dnephin · 2016-11-22T17:00:10Z

engine/swarm/stack-deploy.md

+
+1.  Create the stack with `docker deploy`:
+
+        $ docker deploy --compose-file docker-compose.yml stackdemo


docker stack deploy

dnephin · 2016-11-22T17:00:48Z

engine/swarm/stack-deploy.md

+    The last argument is a name for the stack. Each network, volume and service
+    name is prefixed with the stack name.
+
+2.  Check that it's running with `docker service ls`:


docker stack services stackdemo might be more appropriate here?

dnephin · 2016-11-22T17:01:20Z

engine/swarm/stack-deploy.md

+        Removing service stackdemo_redis
+        Removing network stackdemo_default
+
+4.  Bring the registry down ith `docker service rm`:


s/ith/with/

aanand · 2016-11-22T17:11:26Z

@dnephin Thanks! Addressed.

dnephin

LGTM

mdlinville · 2016-11-22T23:21:10Z

Oops, please rebase your work on vnext-engine branch since it requires 1.13.

mdlinville · 2016-11-22T23:22:55Z

engine/swarm/stack-deploy.md

+a stack description in the form of a [Compose file](/compose/compose-file.md).
+
+The `docker stack deploy` command supports any Compose file of version "3.0" or
+above. If you have an older version, upgrading is simple - see the


Let's not editorialize about how simple it is. :) Something like "If you have an older version, see ."

mdlinville · 2016-11-22T23:24:53Z

engine/swarm/stack-deploy.md

+Because a swarm consists of multiple Docker Engines, a registry is required to
+distribute images to all of them. You can use the
+[Docker Hub](https://hub.docker.com), or maintain your own, but for the purposes
+of this tutorial it's sufficient to create a throwaway registry.


change "it's sufficient to create a throwaway registry" to something like "This tutorials creates a simple registry, which you can discard afterward."

mdlinville · 2016-11-22T23:25:15Z

engine/swarm/stack-deploy.md

+
+        $ docker service create --name registry --publish 5000:5000 registry:2
+
+2.  Check its status with `docker service ls`:


Check the status of the registry

mdlinville · 2016-11-22T23:25:40Z

engine/swarm/stack-deploy.md

+of this tutorial it's sufficient to create a throwaway registry.
+
+1.  Start the registry as a service on your swarm:
+


Please use fenced code blocks instead of relying on indentation.

mdlinville · 2016-11-22T23:26:07Z

engine/swarm/stack-deploy.md

+2.  Check its status with `docker service ls`:
+
+        $ docker service ls
+        ID            NAME      REPLICAS  IMAGE                                                                               COMMAND


As above, fenced code blocks. Please separate the command input from the output with a carriage return.

mdlinville · 2016-11-22T23:27:23Z

engine/swarm/stack-deploy.md

+
+2.  Create a file called `app.py` in the project directory and paste this in:
+
+        from flask import Flask


When you change this to a fenced version, use Dockerfile as the highlighter.

```Dockerfile From flask import Flask

mdlinville · 2016-11-22T23:28:36Z

engine/swarm/stack-deploy.md

+        RUN pip install -r requirements.txt
+        CMD ["python", "app.py"]
+
+5.  Finally, create a file called `docker-compose.yml` and paste this in:


s/Finally,//

mdlinville · 2016-11-22T23:29:07Z

engine/swarm/stack-deploy.md

+
+5.  Finally, create a file called `docker-compose.yml` and paste this in:
+
+        version: '3'


Use fences for this code block and designate it as yaml in the highlighter.

mdlinville · 2016-11-22T23:29:37Z

engine/swarm/stack-deploy.md

+        Creating stackdemo_redis_1
+        Creating stackdemo_web_1
+
+2.  Check that it's running with `docker-compose ps`:


Check that the app is running...

aanand · 2016-11-23T11:18:00Z

Rebased on vnext-engine and addressed @mstanleyjones' comments. I don't have permission to view the build result, so I don't know why it's failing, sorry!

aanand · 2016-11-23T11:22:11Z

By the way, this tutorial also depends on Compose version 1.10, which isn't out yet. I don't know if that affects what branch it should be rebased on.

mdlinville · 2016-11-23T18:11:06Z

yeah, sorry that you can't see the Netlify build failure logs. Netlify is working to make this feature available. I'll have a look and let you know what's going on.

We should probably add a milestone for Compose 1.10 and tag this into that milestone as well. As far as the branches, there is a vnext-compose but let's keep it in vnext-engine for now, and we can work onto getting it into all the places it needs to go.

cc/ @londoncalling can you please create the milestone and tag this into it?

mdlinville · 2016-11-23T18:57:42Z

Also the Netlify check doesn't apply to vnext-engine branch right now, so ignore its failure. I had to change the base in the pull request in Github too (the Edit button next to the PR title). Now it is correctly only showing one commit in the PR.

mdlinville

Looking great! Just a few style-related tweaks for highlighting, and then this is ready. Thanks!

mdlinville · 2016-11-23T18:58:43Z

engine/swarm/stack-deploy.md

+
+1.  Start the registry as a service on your swarm:
+
+    ```


Please add the bash highlighter after the fence. like this:

```bash

Also add it to the other codeblocks that are terminal commands. There are lots of other highlighters such as markdown, dockerfile, json, yaml, go, etc.

mdlinville · 2016-11-23T19:00:05Z

engine/swarm/stack-deploy.md

+
+3.  Create a file called `requirements.txt` and paste these two lines in:
+
+    ```


For this one you can use the none highlighter.

Signed-off-by: Aanand Prasad <[email protected]>

aanand · 2016-11-25T10:42:45Z

Tagged all the code blocks with the appropriate highlighter, per @mstanleyjones' advice

mdlinville

Looks great! Thanks for this.

dnephin reviewed Nov 22, 2016

View reviewed changes

aanand force-pushed the deploy-composefile branch from 0ca615c to 5010fdb Compare November 22, 2016 17:11

aanand force-pushed the deploy-composefile branch from 5010fdb to a6ff281 Compare November 22, 2016 17:14

dnephin approved these changes Nov 22, 2016

View reviewed changes

vdemeester mentioned this pull request Nov 22, 2016

Add 1st draft of docker deploy --compose-file #672

Closed

mdlinville changed the base branch from master to vnext-engine November 22, 2016 23:20

mdlinville changed the base branch from vnext-engine to master November 22, 2016 23:21

mdlinville added this to the engine/1.13.0 milestone Nov 22, 2016

mdlinville suggested changes Nov 22, 2016

View reviewed changes

aanand force-pushed the deploy-composefile branch from a6ff281 to c5fa76e Compare November 23, 2016 11:12

mdlinville changed the base branch from master to vnext-engine November 23, 2016 18:56

mdlinville suggested changes Nov 23, 2016

View reviewed changes

First version of stack deployment tutorial

da3b4ff

Signed-off-by: Aanand Prasad <[email protected]>

aanand force-pushed the deploy-composefile branch from c5fa76e to da3b4ff Compare November 25, 2016 10:41

thaJeztah mentioned this pull request Nov 26, 2016

Support docker stack deploy from a Compose file moby/moby#27998

Merged

mdlinville approved these changes Nov 28, 2016

View reviewed changes

mdlinville merged commit 2bd57a4 into docker:vnext-engine Nov 28, 2016


		1. Create the stack with `docker deploy`:

		$ docker deploy --compose-file docker-compose.yml stackdemo


		$ docker service create --name registry --publish 5000:5000 registry:2

		2. Check its status with `docker service ls`:

		of this tutorial it's sufficient to create a throwaway registry.

		1. Start the registry as a service on your swarm:


		2. Create a file called `app.py` in the project directory and paste this in:

		from flask import Flask


		5. Finally, create a file called `docker-compose.yml` and paste this in:

		version: '3'


		3. Create a file called `requirements.txt` and paste these two lines in:

		```

Comments

Conversation

aanand commented Nov 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnephin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aanand commented Nov 22, 2016

Uh oh!

dnephin left a comment

Choose a reason for hiding this comment

Uh oh!

mdlinville commented Nov 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aanand commented Nov 23, 2016

Uh oh!

aanand commented Nov 23, 2016

Uh oh!

mdlinville commented Nov 23, 2016

Uh oh!

mdlinville commented Nov 23, 2016

Uh oh!

mdlinville left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aanand commented Nov 25, 2016

Uh oh!

mdlinville left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aanand commented Nov 22, 2016 •

edited

Loading