Add 1st draft of docker deploy --compose-file#672
Closed
vdemeester wants to merge 1 commit intodocker:vnext-enginefrom
Closed
Add 1st draft of docker deploy --compose-file#672vdemeester wants to merge 1 commit intodocker:vnext-enginefrom
vdemeester wants to merge 1 commit intodocker:vnext-enginefrom
Conversation
thaJeztah
requested changes
Nov 21, 2016
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
just some nits I spotted, I'll do a more thorough review later :D
engine/swarm/deploy-composefile.md
Outdated
| ## Create our stack | ||
|
|
||
| The stack used in this guide is inspired by the [example voting | ||
| app](https://github.com/docker/example-voting-app). This stack consits of : |
engine/swarm/deploy-composefile.md
Outdated
|
|
||
| redis: | ||
| image: redis:alpine | ||
| container_name: redis |
Member
There was a problem hiding this comment.
I don't think we need (or should have) the container_name here?
vdemeester
force-pushed
the
compose-to-swarm
branch
from
54760db to
5898f31
Compare
This is a rough guide to deploy a compose file using docker deploy. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
compose-to-swarm
branch
from
5898f31 to
154ed81
Compare
Contributor
Author
|
Closing in favor of #685 👼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the proposed changes
Adds documentation on the new compose to swarm feature in the engine — making it possible to use a compose file to deploy services, with
docker deploy --compose-file ….Unreleased project version
For 1.13.0 GA.
Related issue
Not aware if there is an issue in this repo on that or not 👼 but this should fix moby/moby#28414 👼
Related issue or PR in another project
moby/moby#27998
Please take a look
@mstanleyjones @thaJeztah
It's a really simple draft to start the process of documenting the feature. It's probably a little bit poorly written and misses some informations (like the list of forbidden/unsupported elements and the reason why)