documenting rateLimit wich leads to the confusion of #28641#670
Merged
mdlinville merged 2 commits intodocker:masterfrom Dec 19, 2016
Merged
documenting rateLimit wich leads to the confusion of #28641#670mdlinville merged 2 commits intodocker:masterfrom
mdlinville merged 2 commits intodocker:masterfrom
Conversation
Contributor
|
Deploy preview ready! Built with commit 6bda312 |
mdlinville
pushed a commit
to wallyqs/docker.github.io
that referenced
this pull request
Nov 22, 2016
The format for node advertisement in swarm and docker engine (for networking) is the same, and can be shared. Doing so allows us to start toward removing the swarm-join container, and improves our HA situation after engine discovery is run. Resolves docker#670. Specifically, swarm was previously somewhat HA: if you set up 1 controller, 2 replicas and 1 node, then you could lose the controller and still remain functional unless the swarm node needed to restart. This change improves HA by removing the above failure mode as long as engine discovery has been run and is up to date. See also docker-archive/classicswarm#1368 which implemented this flag, and lays out the future scenario we hope to achieve, and also docker#1032 which is our goal of removing swarm join with automatical engine discovery.
mdlinville
pushed a commit
to amincheloh/docker.github.io
that referenced
this pull request
Nov 28, 2016
The format for node advertisement in swarm and docker engine (for networking) is the same, and can be shared. Doing so allows us to start toward removing the swarm-join container, and improves our HA situation after engine discovery is run. Resolves docker#670. Specifically, swarm was previously somewhat HA: if you set up 1 controller, 2 replicas and 1 node, then you could lose the controller and still remain functional unless the swarm node needed to restart. This change improves HA by removing the above failure mode as long as engine discovery has been run and is up to date. See also docker-archive/classicswarm#1368 which implemented this flag, and lays out the future scenario we hope to achieve, and also docker#1032 which is our goal of removing swarm join with automatical engine discovery.
mdlinville
suggested changes
Dec 1, 2016
mdlinville
left a comment
mdlinville
left a comment
There was a problem hiding this comment.
Thanks for tackling this. Please consider my rewording suggestions and please rebase against master and resolve the merge conflict if possible. Let me know if you need help with the rebase.
engine/admin/logging/journald.md
Outdated
| ## Journald configuration | ||
|
|
||
| Docker hosts with many containers may produce massive amounts of log-messages. | ||
| The default configuration of journald is to limit the number of messages stored per service per time-unit. |
There was a problem hiding this comment.
Please put back-ticks around journald. Consider rewriting to something like "By default, journald limits the number of messages stored per service per time-unit."
engine/admin/logging/journald.md
Outdated
| Docker hosts with many containers may produce massive amounts of log-messages. | ||
| The default configuration of journald is to limit the number of messages stored per service per time-unit. | ||
|
|
||
| Applications with need for large-scale logging wil probably need to configure `RateLimitIntervalSec` and `RateLimitBurst` in the journald configuration file. |
There was a problem hiding this comment.
typo: "wil"
Consider rewording because applications don't configure. "If your applications need large-scale logging, configure RateLimitIntervalSec and RateLimitBurst in the journald configuration file."
mdlinville
force-pushed
the
feature/journald_rate
branch
from
6bda312 to
0ddda59
Compare
|
I rebased your commits and used this as an opportunity to improve the formatting in the rest of the file. I'll merge after the PR finishes running tests. |
mdlinville
approved these changes
Dec 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the proposed changes
Documenting the fact that
journaldby default will skip messages if it exceeds a certain rateRelated issue
Relates to my issue #28641 where i blame the logging driver, when the problem were system configuration.