Pull docker refs from git#511
Pull docker refs from git#511johndmulhausen merged 2 commits intodocker:masterfrom mdlinville:pull_docker_refs_from_git
Conversation
|
Deploy preview ready! Built with commit d2e8ccf |
|
@johndmulhausen @thaJeztah this is ready to go. We did some testing locally and verified that it works. This is just for |
|
cc/ @dnephin |
|
@dnephin @thaJeztah @icecrime I just want to be really sure that this is necessary before we pull the trigger. You have said that after a version ships, the reference docs for that engine version are "dead" and that nobody is editing the v1.12 docs over in docker/docker at this point, correct? |
Changes are made by cherry-picking fixes from the master branch into the 1.12.x branch. That way, we don't "maintain" two separate versions, but can incorporate changes in to the "current" docs (so are able to update documentation between releases). |
|
Rebased to address conflicts. I think this is ready to go. Agree, @johndmulhausen ? |
|
Argh let me rebase again. |
Update Dockerfile and NOT_EDITED_HERE manifest Signed-off-by: Misty Stanley-Jones <[email protected]>
Signed-off-by: Misty Stanley-Jones <[email protected]>
|
@johndmulhausen I think this is ready (again)... |
|
Alright, pulling this in after discussion w/ @mstanleyjones. Thanks, all! |
4 participants
Describe the proposed changes
Remove
docker/dockerref docs, plugin docs, anddeprecated.mdfrom docker.github.io sourceModify Dockerfile to pull these files/folders from the
docker/dockerrepo insteadModify the NOT_EDITED_HERE manifest to stop referring to these files / folders
Unreleased project version
n/a
Related issue
n/a
Related issue or PR in another project
n/a
Please take a look
@johndmulhausen I'm not sure exactly how to test this Can you sanity-check it?
cc/ @thaJeztah @dnephin