Skip to content

Default highlight.js off, dockerfile > conf highlighting, pygments#2757

Merged
johndmulhausen merged 4 commits intomasterfrom
nohighlight
Apr 14, 2017
Merged

Default highlight.js off, dockerfile > conf highlighting, pygments#2757
johndmulhausen merged 4 commits intomasterfrom
nohighlight

Conversation

@johndmulhausen
Copy link
Contributor

@johndmulhausen johndmulhausen commented Apr 13, 2017

Changes

Why?

background-color: #f5f5f5;
border: 1px solid #ccc;
border-radius: 4px;
overflow-x: scroll!important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen now if we have long code lines? We don't want them to wrap because it can cause trouble in pasting.

Copy link
Contributor Author

@johndmulhausen johndmulhausen Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They get scrollbars; this is not the rule that actually implements them, this is creating double scrollbars (one active, one inactive). That's why this rule must die.

color: #333;
word-break: normal!important;
word-wrap: break-word;
word-break: normal!important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should configure atom not to change white space in lines you didn't otherwise touch.

@@ -0,0 +1,66 @@
.highlight .hll { background-color: #ffffcc }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to import the theme we actually use, right?

@johndmulhausen
Copy link
Contributor Author

LGTM, merging

@johndmulhausen johndmulhausen merged commit add2f68 into master Apr 14, 2017
@johndmulhausen johndmulhausen deleted the nohighlight branch April 14, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants