Skip to content

build: annotations#18891

Merged
crazy-max merged 4 commits intodocker:mainfrom
dvdksn:build-annotations
Dec 14, 2023
Merged

build: annotations#18891
crazy-max merged 4 commits intodocker:mainfrom
dvdksn:build-annotations

Conversation

@dvdksn
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn commented Dec 10, 2023

Signed-off-by: David Karlsson [email protected]

Add docs for build annotations

@dvdksn dvdksn requested a review from crazy-max as a code owner December 10, 2023 20:20
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 10, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 37b84b1
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/657ace7cbf62f80008811d54
😎 Deploy Preview https://deploy-preview-18891--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the area/build Relates to Dockerfiles or docker build command label Dec 10, 2023
@dvdksn dvdksn requested a review from a team December 10, 2023 20:21
Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but awesome work @dvdksn, thanks!

Comment thread content/build/building/annotations.md
Comment thread content/build/building/annotations.md
Comment thread content/build/building/annotations.md Outdated
Comment thread content/build/building/annotations.md
Comment thread content/build/ci/github-actions/annotations.md Outdated
@dvdksn dvdksn requested a review from crazy-max December 11, 2023 16:01
crazy-max
crazy-max previously approved these changes Dec 11, 2023
Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.
That line highlight feature makes stuff so much easier to read.

My only suggestion, for the "specify annotation level section" section, as someone not familiar with this, output of the inspect command for each example would help me visualize it better. Not very necessary because the "Annotations describe OCI image components, such as manifests, indexes, and descriptor" links helped me understand the levels, and the example in the inspect section showed a few levels with annotations.

@github-actions github-actions Bot added the dependencies Vendoring, packaging updates label Dec 14, 2023
@dvdksn dvdksn requested a review from crazy-max December 14, 2023 09:33
Signed-off-by: David Karlsson <[email protected]>
SHA: b68ee824c67342b19c4208dbfef40a3498e17a7b

Signed-off-by: David Karlsson <[email protected]>
@crazy-max
Copy link
Copy Markdown
Member

As discussed we should have a workflow to sanitize go modules like we do in buildx: https://github.com/docker/buildx/blob/master/hack/dockerfiles/vendor.Dockerfile

@crazy-max crazy-max merged commit 80b0ef6 into docker:main Dec 14, 2023
@dvdksn dvdksn deleted the build-annotations branch December 14, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command dependencies Vendoring, packaging updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants