registry: prune registry docs #18390
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
requested review from
aevesdocker,
craig-osterhout and
stephaurelio
as code owners
|
PTAL @thaJeztah |
|
When I click on the previews for storage drivers I get |
|
@milosgajdos where did you find a link to the storage-drivers page? I thought I'd removed them all The redirects I added in 5ab929b should point you to the markdown files in |
Hmm, ok, strange, because they reference full URLs 🤔 |
|
@milosgajdos where are you seeing this link? |
|
I go here https://deploy-preview-18390--docsdocker.netlify.app/ then I search for some registry stuff |
|
@milosgajdos ah yeah the search index is from production, but we strip the base url prefix from the search results. Those search results will go away once we reindex the site in prod. |
data/redirects.yml
Outdated
| - /go/filter/ | ||
|
|
||
| # Registry | ||
| "https://github.com/distribution/distribution/blob/main/docs/index.md": |
There was a problem hiding this comment.
should we use permalinks for these (tag or release branch)?
As these are transitional redirects (we stopped publishing these parts of the docs), we probably don't want to continue maintaining the links, and if (some of) these may be removed or may move in upstream, we could get those redirects to be broken otherwise.
There was a problem hiding this comment.
As an alternative, we could create a stub/landing page that describes where docs can be found, and redirect all of these to that page.
There was a problem hiding this comment.
we are working on getting GH pages docs sorted in upstream and will point these docs to those when done
There was a problem hiding this comment.
Yeah, mostly considering that "how to run <some project in the container ecosystem> is somewhat out of scope for our docs, so even with those in place, we should reduce maintenance on our side (and could just point to the upstream github repo)
There was a problem hiding this comment.
PR for publishing registry docs standalone: distribution/distribution#4101
There was a problem hiding this comment.
Removed these redirects and added a stub page at /registry/
dvdksn
force-pushed
the
remove-registry
branch
2 times, most recently
from
f635676 to
641625c
Compare
dvdksn
force-pushed
the
remove-registry
branch
from
641625c to
cd3f421
Compare
Removes most of the registry docs, keeping only: - How to set up a Docker Hub mirror The canonical location for registry/distribution docs from now on is: https://distribution.github.io/distribution/ Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
remove-registry
branch
from
cd3f421 to
98c38b6
Compare
<!--Delete sections as needed --> ## Description Re-add registry reference from point in time of deletion at #18390, not upstream. https://deploy-preview-22497--docsdocker.netlify.app/reference/api/registry/latest/ https://deploy-preview-22497--docsdocker.netlify.app/reference/api/registry/auth/ ## Related issues or tickets ENGDOCS-2577 ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Signed-off-by: Craig <[email protected]> Co-authored-by: sheltongraves <[email protected]> Co-authored-by: Sarah Sanders <[email protected]>
4 participants
Removes registry documentation from docs.docker.com
Canonical location for registry/distribution docs is now:
https://distribution.github.io/distribution/
Signed-off-by: David Karlsson [email protected]
Stub preview: /registry/