engine: fix ipv6 example for Compose#18119
Merged
aevesdocker merged 1 commit intodocker:mainfrom Sep 7, 2023
Merged
Conversation
See https://github.com/compose-spec/compose-spec/blob/796804a634e4a1fd48a70f0b0b0e02f1a3a97890/06-networks.md#L168-L196 (Note: there's a typo there too, which is being fixed as compose-spec/compose-spec#417. The indentation is wrong, but the description of the fields/hierarchy is correct.) Signed-off-by: Milas Bowman <[email protected]>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
I think we might want to cross-link to this guide from the Compose docs, and perhaps have a link back to https://docs.docker.com/compose/compose-file/06-networks/ here? 😇 (cc @aevesdocker as Compose 🧙🏻♀️) |
aevesdocker
approved these changes
Sep 7, 2023
Contributor
|
Yes agreed! Will create follow up PRs for this. Muchas gracias @milas |
milas
added a commit
to milas/docker-mailserver
that referenced
this pull request
Sep 7, 2023
This was unfortunately slightly incorrect due to a mistake in the official Docker docs being propagated, which has been fixed upstream with docker/docs#18119. The subnet must be specified as part of `ipam.configs`. Refer to the official Compose Spec for more details: * https://docs.docker.com/compose/compose-file/06-networks/#ipam
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed the example for creating an IPv6 network in Compose YAML.
See https://github.com/compose-spec/compose-spec/blob/796804a634e4a1fd48a70f0b0b0e02f1a3a97890/06-networks.md#L168-L196
(Note: there's a typo there too, which is being fixed as well. The indentation is wrong, but the description of the fields/hierarchy is correct.)
Related issues (optional)