add "go" redirect for deprecated image formats#17858
Merged
thaJeztah merged 1 commit intodocker:mainfrom Aug 2, 2023
Merged
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
dvdksn
reviewed
Aug 2, 2023
_redirects.yml
Outdated
| # - Docker Image manifest version 2, schema 1 (https://github.com/distribution/distribution/blob/ff2bce27319a0a0bca924820c353fae3b9046e91/docs/spec/manifest-v2-1.md) | ||
| # | ||
| # TODO(thaJeztah) We need a better page describing the image formats (and deprecated ones) | ||
| - /go/image-specs/ |
Contributor
There was a problem hiding this comment.
If this redirect is meant to handle specifically the deprecated format, maybe we should include that in the slug.
Suggested change
| - /go/image-specs/ | |
| - /go/deprecated-image-specs/ |
Member
Author
There was a problem hiding this comment.
Yes, I'm fine with that. Let me update 👍
Member
Author
There was a problem hiding this comment.
Do you think plural or singular would be better? What feels most natural to you to type?
We currently print the full URL in warnings, and we may want to create a
better page for this at some point;
docker pull docker:1.0.1
1.0.1: Pulling from library/docker
Image docker.io/library/docker:1.0.1 uses outdated schema1 manifest format. Please upgrade to a schema2 image for better future compatibility. More information at https://docs.docker.com/registry/spec/deprecated-schema-v1/
Adding a new "/go/" redirect, so that we can point it to the relevant
content as we go. I tried to keep the URl somewhat short, so didn't
include "deprecated", but naming is hard, so input welcome.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
legacy_image_redirect
branch
from
00500ff to
8488da0
Compare
Member
Author
|
Updated 👍 kept it plural |
dvdksn
approved these changes
Aug 2, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently print the full URL in warnings, and we may want to create a better page for this at some point;
Adding a new "/go/" redirect, so that we can point it to the relevant content as we go. I tried to keep the URl somewhat short, so didn't include "deprecated", but naming is hard, so input welcome.
Related issues (optional)