Update 'usingdocker' tutorial to name the container#1165
Merged
mdlinville merged 1 commit intodocker:masterfrom Jan 18, 2017
mdlinville:tutorial_explain_naming
Merged
Update 'usingdocker' tutorial to name the container#1165mdlinville merged 1 commit intodocker:masterfrom mdlinville:tutorial_explain_naming
mdlinville merged 1 commit intodocker:masterfrom
mdlinville:tutorial_explain_naming
Conversation
Closed
Do some clean-up while I'm in there
sanscontext
reviewed
Jan 18, 2017
|
|
||
| * The `-d` flag runs the container in the background (as a so-called daemon). | ||
| * The `--name my_webapp` flag names the container `my_webapp`. If you do not | ||
| specify a name, Docker creates a random (and sometimes amusing) name for the |
Contributor
There was a problem hiding this comment.
+1 on sometimes amusing, thank you :D
sanscontext
reviewed
Jan 18, 2017
|
|
||
| In this case Docker has exposed port 5000 (the default Python Flask | ||
| port) on port 49155. | ||
|
|
Contributor
There was a problem hiding this comment.
Hm, I felt this was kinda useful actually. What's your thinking in removing it?
Author
There was a problem hiding this comment.
I left it in, just moved it up a bit.
sanscontext
approved these changes
Jan 18, 2017
Contributor
sanscontext
left a comment
sanscontext
left a comment
There was a problem hiding this comment.
LGTM with one question. Thank you for tackling this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update 'usingdocker' tutorial to name the container and do some basic clean-up on the topic's mark-up
Related issues (optional)
Fixes #990
Replaces #1163