Add go/buildkit redirect#11621
Merged
thaJeztah merged 1 commit intodocker:masterfrom Oct 26, 2020
Merged
Conversation
This URL will be used in the docker cli to direct users to instructions on enabling buildkit. With this PR, https://docs.docker.com/go/buildkit/ will redirect to https://docs.docker.com/develop/develop-images/build_enhancements/#to-enable-buildkit-builds Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@usha-mandya @tiborvass PTAL |
|
Deploy preview for docsdocker ready! Built with commit 7491d10 |
thaJeztah
commented
Oct 26, 2020
Comment on lines
+2
to
+4
| title: How to enable BuildKit | ||
| description: Instructions on enabling BuildKit | ||
| keywords: BuildKit, docker build, configuration |
Member
Author
There was a problem hiding this comment.
I think these are redundant as they're not rendered anywhere for redirects. That said, they provide a bit of details as to what the redirect is for, so didn't really hurt to have them here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This URL will be used in the docker cli to direct users to instructions on enabling buildkit.
With this PR, https://docs.docker.com/go/buildkit/ will redirect to https://docs.docker.com/develop/develop-images/build_enhancements/#to-enable-buildkit-builds
relates to docker/cli#2809