Conversation
Code is already highlighted through "rouge", so enabling highlight.js only resulted in code being parsed/highlighted _twice_. This patch removes highlight.js and updates the "github" stylesheet to be compatible with rouge. Signed-off-by: Sebastiaan van Stijn <[email protected]>
mdlinville
left a comment
There was a problem hiding this comment.
LGTM from a quick perusal of a few pages I know have highlighted code...
|
Datacenter looks good. @sanscontext where's that page with all possible markdown permutations you've created? Is that page OK? |
|
@joaofnfernandes https://deploy-preview-1021--psychologist-duck-16578.netlify.com/test/#/some-code-block-samples Looks pretty good, but looks like YAML changed how it's broken, and it might not have |
|
It seems that Rouge has support for Docker files in their latest version (2.0.7), but |
|
While I'd love to do this, Jekyll does not support the Rouge version where Dockerfile support was added (which was 2.0.4). As you see here, it's dependency is set to It's not a GitHub Pages thing; no idea when Jekyll will get their act together. |
|
Trying this Gemfile: You get the incompatibility error when running Trying this: Succeeds but bundler reverts way back to Jekyll 2.5.3, probably because that was before it had dependency checking for Rouge: https://rubygems.org/gems/jekyll/versions/2.5.3 The very next version past 2.5.3, which was 3.0.0, was when Jekyll pinned its Rouge dependency at |
|
In the mean time we can all watch this issue: jekyll/jekyll#5556 |
a32d6dc to
35568d5
Compare
Removing my +1 on this one so it doesn't get merged accidentally.
|
Closing in favor of #2757. We can use |
Code is already highlighted through "rouge", so
enabling highlight.js only resulted in code
being parsed/highlighted twice.
This patch removes highlight.js and updates
the "github" stylesheet to be compatible
with rouge.
/cc @joaofnfernandes @mstanleyjones @johndmulhausen