Improved description for Hello-World#1012
Merged
mdlinville merged 1 commit intodocker:masterfrom Jan 18, 2017
Merged
Conversation
Adds more detail for people to be able to understand how to build the Hello World using FROM scratch.
mdlinville
approved these changes
Jan 18, 2017
mdlinville
left a comment
mdlinville
left a comment
There was a problem hiding this comment.
LGTM but @londoncalling should take a look.
|
Actually I am going to merge this for now. |
Contributor
|
@mstanleyjones @ScottFred Thanks, looks great! I will test the commands as soon as I can, but will trust they work for now :-) Nice contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more detail for people to be able to understand how to build the Hello World using FROM scratch.
Proposed changes
There was a big leap in understanding needed when reading the current page about using "From scratch" to build the hello-world.c code and being able to package it in a Docker image. After figuring out myself, I thought it would be good to share with the rest of the world here.