update node remove test status code from 500 to >= 400#1621
Merged
shin- merged 1 commit intodocker:masterfrom May 22, 2017
Merged
Conversation
Signed-off-by: allencloud <[email protected]>
thaJeztah
approved these changes
May 18, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (not a maintainer here)
|
LGTM (not a maintainer) |
shin-
approved these changes
May 22, 2017
allencloud
deleted the
update-swarm-remove-test-status-code-from-500-to-400
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allencloud [email protected]
This PR is related to PR #1605.
This is my fault to ignore test the following status code at the test case
test_remove_main_node. The original thought of this PR is from moby/moby#32122.What I did:
ping @shin- @stevvooe