update docker-py test status code from 500 to 400#1605
Conversation
|
We should test both 500 and 400 so the test still validates pre-existing releases. |
|
How about |
|
The ideal situation from an API consumer standpoint would be for status code changes to happen as rarely as possible, and to not affect existing API versions. I understand why that's not necessarily possible, and I know from our previous discussions that you do not want anyone relying on status codes to detect and identify errors, but at this time, and until proper error codes become an integral part of the engine API, this is the only indicator users have. If that type of test can be a small reminder of that, and the possible consequences of that type of change in the real world, I don't necessarily see it as a bad thing. |
Signed-off-by: allencloud <[email protected]>
allencloud
force-pushed
the
update-test-status-code-from-500-to-400
branch
from
50f6179 to
717459d
Compare
|
@shin- @stevvooe And Yeah, actually I understand the consequence of changing status code, while I think we still need to pay more attention on locking the APIs and be very careful. |
3 participants
Since PR in moby/moby moby/moby#32122 hopes to get status code from rpc code which is determined in swarmkit.
So, when we made this rule, we found that some status code from moby/moby needs changed.
While in integration test of moby/moby, we will use docker-py to test daemon's API. It always fails in this status code. So I try to make this change.
ping @shin- @thaJeztah @stevvooe
Signed-off-by: allencloud [email protected]