Skip to content

A new user-focused API#1186

Merged
shin- merged 17 commits intodocker:masterfrom
bfirsh:two-point-oh
Nov 23, 2016
Merged

A new user-focused API#1186
shin- merged 17 commits intodocker:masterfrom
bfirsh:two-point-oh

Conversation

@bfirsh
Copy link
Contributor

@bfirsh bfirsh commented Sep 6, 2016 •
edited
Loading

An implementation of #1086.

Todo

  • Thorough unit tests for new API
  • Add run options which span both create and host config (e.g. ports and volumes)
  • Full set of integration tests for containers
  • Implement complete set of methods for images with integration tests
  • Add remaining objects to new API
  • Documentation
  • Add docstrings
  • Better service options?
  • Handle image methods that apply to multiple tags on a repository.
  • Squash commits a bit

Nice to have

@bfirsh bfirsh force-pushed the two-point-oh branch 17 times, most recently from 1c50e24 to bf71a46 Compare September 9, 2016 14:42
@bfirsh bfirsh force-pushed the two-point-oh branch 7 times, most recently from c035c21 to d073d77 Compare September 9, 2016 16:37
@shin- shin- added this to the 2.0.0 milestone Sep 10, 2016
bfirsh added 12 commits November 22, 2016 17:03
@bfirsh
Remove AutoVersionClient
c7903f0 
Just do Client(version='auto').

Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Rename Client to APIClient
9daa320 
Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Make ping return bool instead of string
dac7174 
Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Rename DockerClientTest to BaseAPIClientTest
e055a1c 
Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Move APIClient tests into single file
39900c5 
For some reason this was spread across two files.

Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Split out base integration test for APIClient
6334312 
So the cleanup stuff can be reused for model tests.

Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Add random_name test helper
d98a879 
Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Move contributing docs to CONTRIBUTING.md
ed959f2 
CONTRIBUTING.md is the place that GitHub expects it to be.

Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Add docstrings to low-level API
f32c0c1 
Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Add new user-focused API
1984f68 
See docker#1086

Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Add new Sphinx documentation
c7a3aa7 
Initial work thanks to @aanand.

Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Add helpful error for APIClient methods on Client
b5f7d38 
Signed-off-by: Ben Firshman <[email protected]>
@shin-
Copy link
Contributor

shin- commented Nov 23, 2016

The only thing that's outstanding to me still is this thread: #1186 (comment)

But I think we can address it separately before the release. Let's go ahead and merge this. 👍

@shin- shin- merged commit 8478491 into docker:master Nov 23, 2016
@bfirsh
Copy link
Contributor Author

bfirsh commented Nov 23, 2016

Yippee, thank you!

2

@bfirsh bfirsh mentioned this pull request Nov 23, 2016
Merged
@shin- shin- mentioned this pull request Nov 24, 2016
Merged
This was referenced Nov 26, 2016
Closed
Closed
This was referenced Nov 28, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
@benfasoli benfasoli mentioned this pull request Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@aanand aanand aanand left review comments

@dnephin dnephin dnephin left review comments

@justincormack justincormack justincormack left review comments

@shin- shin- shin- left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/0-triage

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@bfirsh @aanand @dnephin @shin- @justincormack @GordonTheTurtle