Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/docker-py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.1.0
Choose a base ref
...
head repository: docker/docker-py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.2.0
Choose a head ref
  • 10 commits
  • 20 files changed
  • 8 contributors

Commits on Feb 6, 2020

  1. set logging level of paramiko to warn 

    Signed-off-by: Till Riedel <[email protected]>
    @riedel @ulyssessouza
    riedel authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    1e56722 View commit details
    Browse the repository at this point in the history

  2. set host key policy for ssh transport to WarningPolicy() 

    Signed-off-by: Till Riedel <[email protected]>
    @riedel @ulyssessouza
    riedel authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    bc6777e View commit details
    Browse the repository at this point in the history

  3. obey Hostname Username Port and ProxyCommand settings from .ssh/config 

    Signed-off-by: Till Riedel <[email protected]>
    @riedel @ulyssessouza
    riedel authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    ed9b208 View commit details
    Browse the repository at this point in the history

  4. Fix CI labels so we run on amd64 nodes 

    Signed-off-by: Nicolas De Loof <[email protected]>
    @ndeloof @ulyssessouza
    ndeloof authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    a67d180 View commit details
    Browse the repository at this point in the history

  5. Fix win32pipe.WaitNamedPipe throw exception in windows container. 

    Signed-off-by: Renlong Tu <[email protected]>
    @SLdragon @ulyssessouza
    SLdragon authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    61e2d5f View commit details
    Browse the repository at this point in the history

  6. Version bump 

    Signed-off-by: Christopher Crone <[email protected]>
    @chris-crone @ulyssessouza
    chris-crone authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    9b0d07f View commit details
    Browse the repository at this point in the history

  7. Fix ImageCollectionTest.test_pull_multiple flakiness 

    The ImageCollectionTest.test_pull_multiple test performs a `docker pull` without
a `:tag` specified) to pull all tags of the given repository (image).

After pulling the image, the image(s) pulled are checked to verify if the list
of images contains the `:latest` tag.

However, the test assumes that all tags of the image are tags for the same
version of the image (same digest), and thus a *single* image is returned, which
is not always the case.

Currently, the `hello-world:latest` and `hello-world:linux` tags point to a
different digest, therefore the `client.images.pull()` returns multiple images:
one image for digest, making the test fail:

    =================================== FAILURES ===================================
    ____________________ ImageCollectionTest.test_pull_multiple ____________________
    tests/integration/models_images_test.py:90: in test_pull_multiple
        assert len(images) == 1
    E   AssertionError: assert 2 == 1
    E    +  where 2 = len([<Image: 'hello-world:linux'>, <Image: 'hello-world:latest'>])

This patch updates the test to not assume a single image is returned, and instead
loop through the list of images and check if any of the images contains the
`:latest` tag.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah @ulyssessouza
    thaJeztah authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    6c29375 View commit details
    Browse the repository at this point in the history

  8. Implement context management, lifecycle and unittests. 

    Signed-off-by: Anca Iordache <[email protected]>
    @ulyssessouza
    Anca Iordache authored and ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    6e44d84 View commit details
    Browse the repository at this point in the history

  9. Bump 4.2.0 

    Signed-off-by: Ulysses Souza <[email protected]>
    @ulyssessouza
    ulyssessouza committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    ab56784 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #2506 from ulyssessouza/4.2.0-release 

    4.2.0 release
    Ulysses Souza authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    1d1532f View commit details
    Browse the repository at this point in the history
Loading