pass: Get: remove redundant stat#323
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 10, 2024
Merged
Conversation
listPassdir already handles "not found" errors, in which case it returns an [empty result][1]. Previously this would return a custom error, but since 1bb9aa3, an empty result produces a `errCredentialsNotFound`, making this check redundant. This patch removes the redundant check. [1]: https://github.com/docker/docker-credential-helpers/blob/f64d6b131b3da07a6337dc63a882e08ce541d1c1/pass/pass.go#L118-L125 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 54.93% 55.28% +0.35%
==========================================
Files 9 9
Lines 628 624 -4
==========================================
Hits 345 345
+ Misses 237 234 -3
+ Partials 46 45 -1 ☔ View full report in Codecov by Sentry. |
crazy-max
approved these changes
May 10, 2024
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listPassdir already handles "not found" errors, in which case it returns an empty result. Previously this would return a custom error, but since 1bb9aa3 (#321), an empty result produces a
errCredentialsNotFound, making this check redundant.This patch removes the redundant check.
- A picture of a cute animal (not mandatory but encouraged)