Skip to content

Dockerfile: update xx to v1.4.0#310

Merged
crazy-max merged 1 commit intodocker:masterfrom
thaJeztah:update_xx
Feb 6, 2024
Merged

Dockerfile: update xx to v1.4.0#310
crazy-max merged 1 commit intodocker:masterfrom
thaJeztah:update_xx

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jan 10, 2024 •
edited
Loading

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2024

Unfortunately; still failing with newer go versions; we'll have to look what's causing it; /cc @crazy-max

91.42 go build -trimpath -ldflags="-s -w -X github.com/docker/docker-credential-helpers/credentials.Version=v0.8.0-10-g59ccf8f -X github.com/docker/docker-credential-helpers/credentials.Revision=59ccf8f9aafca3c2f75d9cafde97f514aa48d2f2 -X github.com/docker/docker-credential-helpers/credentials.Package=github.com/docker/docker-credential-helpers -X github.com/docker/docker-credential-helpers/credentials.Name=docker-credential-osxkeychain" -o "/out/docker-credential-osxkeychain" ./osxkeychain/cmd/
121.4 # github.com/docker/docker-credential-helpers/osxkeychain/cmd
121.4 /usr/local/go/pkg/tool/linux_amd64/link: running arm64-apple-macos10.11-clang failed: exit status 255
121.4 /usr/bin/arm64-apple-macos10.11-ld: 9: sigtool-gensig: not found
121.4 clang: error: unable to execute command: No such file or directory
121.4 clang: error: linker command failed due to signal (use -v to see invocation)

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2024

Maybe we need to update OSXCROSS_VERSION or something

@thaJeztah thaJeztah mentioned this pull request Jan 10, 2024
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2024

Pushed a temporary commit to use xx:master; @crazy-max thinks this may be related to

@crazy-max
Copy link
Copy Markdown
Member

crazy-max commented Jan 10, 2024

Pushed a temporary commit to use xx:master; @crazy-max thinks this may be related to

* [ld: update ld64 and dependencies  tonistiigi/xx#140 (comment)](https://github.com/tonistiigi/xx/pull/140#discussion_r1444242053)

Still sad :(

115.0 # github.com/docker/docker-credential-helpers/osxkeychain/cmd
115.0 /usr/local/go/pkg/tool/linux_amd64/link: running arm64-apple-macos10.11-clang failed: exit status 255
115.0 /usr/bin/arm64-apple-macos10.11-ld: 9: sigtool-gensig: not found

We need new prebuild-ld, I'm looking into it and keep you posted.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2024

arm64-apple-macos10.11-clang looks like that's for a different version than OSXCROSS_VERSION=11.3-r7-debian is that related in any form?

@crazy-max
Copy link
Copy Markdown
Member

crazy-max commented Feb 6, 2024 •
edited
Loading

@thaJeztah Can you try with latest v1.4.0? https://github.com/tonistiigi/xx/releases/tag/v1.4.0

@thaJeztah thaJeztah changed the title Dockerfile: update xx to v1.3.0 Dockerfile: update xx to v1.4.0 Feb 6, 2024
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 6, 2024

updated 🤞

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.23%. Comparing base (292722b) to head (d9632f6).
Report is 33 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   52.23%   52.23%           
=======================================
  Files           9        9           
  Lines         672      672           
=======================================
  Hits          351      351           
  Misses        274      274           
  Partials       47       47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazy-max crazy-max merged commit d622133 into docker:master Feb 6, 2024
@thaJeztah thaJeztah deleted the update_xx branch February 6, 2024 09:10
@BrewTestBot BrewTestBot mentioned this pull request May 23, 2024
Merged
@campaigner-prod campaigner-prod Bot mentioned this pull request Apr 23, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @crazy-max @codecov-commenter