Skip to content

Dockerfile: update golangci-lint to v1.55.2#309

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:update_golangci
Jan 10, 2024
Merged

Dockerfile: update golangci-lint to v1.55.2#309
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:update_golangci

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jan 10, 2024

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 10, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8fc3306) 52.51% compared to head (f110cd3) 52.23%.
Report is 2 commits behind head on master.

Files Patch % Lines
credentials/error.go 0.00% 3 Missing ⚠️
client/client.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   52.51%   52.23%   -0.29%     
==========================================
  Files           9        9              
  Lines         676      672       -4     
==========================================
- Hits          355      351       -4     
  Misses        274      274              
  Partials       47       47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2024

right; looks like XX update isn't working;

 > [linux/amd64->darwin/arm64 build-darwin 1/1] RUN --mount=type=bind,target=.     --mount=type=cache,target=/root/.cache     --mount=type=cache,target=/go/pkg/mod     --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk     --mount=type=bind,source=/tmp/.version,target=/tmp/.version,from=version     --mount=type=bind,source=/tmp/.revision,target=/tmp/.revision,from=version <<EOT (set -ex...):
87.01 + cat /tmp/.revision
87.01 + make build-osxkeychain build-pass PACKAGE=github.com/docker/docker-credential-helpers VERSION=v0.8.0-7-g14358f5 REVISION=14358f5773df4473080864c96cf6aca39d49e8d6 DESTDIR=/out
87.01 go build -trimpath -ldflags="-s -w -X github.com/docker/docker-credential-helpers/credentials.Version=v0.8.0-7-g14358f5 -X github.com/docker/docker-credential-helpers/credentials.Revision=14358f5773df4473080864c96cf6aca39d49e8d6 -X github.com/docker/docker-credential-helpers/credentials.Package=github.com/docker/docker-credential-helpers -X github.com/docker/docker-credential-helpers/credentials.Name=docker-credential-osxkeychain" -o "/out/docker-credential-osxkeychain" ./osxkeychain/cmd/
115.5 # github.com/docker/docker-credential-helpers/osxkeychain/cmd
115.5 /usr/local/go/pkg/tool/linux_amd64/link: running arm64-apple-macos10.11-clang failed: exit status 255
115.5 /usr/bin/arm64-apple-macos10.11-ld: 9: sigtool-gensig: not found
115.5 clang: error: unable to execute command: No such file or directory
115.5 clang: error: linker command failed due to signal (use -v to see invocation)
115.5 
115.5 make: *** [Makefile:27: build-osxkeychain] Error 1

@thaJeztah thaJeztah changed the title Dockerfile: update golangci-lint to v1.55.2, update xx to v1.3.0 Dockerfile: update golangci-lint to v1.55.2 Jan 10, 2024
@thaJeztah thaJeztah requested a review from crazy-max January 10, 2024 15:39
@thaJeztah thaJeztah merged commit 979dcc4 into docker:master Jan 10, 2024
@thaJeztah thaJeztah deleted the update_golangci branch January 10, 2024 17:00
@BrewTestBot BrewTestBot mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumpl rumpl rumpl approved these changes

@laurazard laurazard laurazard approved these changes

@crazy-max crazy-max Awaiting requested review from crazy-max

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @codecov-commenter @rumpl @laurazard