readme: install emulators when building with docker#286
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 28, 2023
Merged
readme: install emulators when building with docker#286thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 55.23% 54.68% -0.56%
==========================================
Files 9 9
Lines 668 673 +5
==========================================
- Hits 369 368 -1
- Misses 256 262 +6
Partials 43 43 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #260
Adds instruction to install emulators to be able to build with Docker. We don't encounter this issue on Docker Desktop as emulators are already installed. On CI we already install emulators with qemu action:
docker-credential-helpers/.github/workflows/build.yml
Lines 137 to 139 in bdd92dd