osxkeychain: match min macos version for xx#283
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 28, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 55.23% 55.23%
=======================================
Files 9 9
Lines 668 668
=======================================
Hits 369 369
Misses 256 256
Partials 43 43
☔ View full report in Codecov by Sentry. |
Member
|
Haven't tried yet, but wondering if we need to update these two lines; docker-credential-helpers/osxkeychain/osxkeychain_darwin.go Lines 4 to 5 in f8e94d9 |
crazy-max
force-pushed
the
fix-osx-min-version
branch
from
abe5b9d to
f53a494
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
fix-osx-min-version
branch
from
f53a494 to
5944f8a
Compare
Member
Author
I think we can keep 10.11 as minimum version looking at the current implementation of the keychain in our codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially solves #280
xxsets a minimal macos version if not set throughMACOSX_VERSION_MINenv var: https://github.com/tonistiigi/xx/blob/3d00d096c8bf894ec29bae5caa5aea81d9c187a5/base/xx-info#L203-L209