Skip to content

vendor: github.com/danieljoos/wincred v1.2.0#271

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_wincred
May 27, 2023
Merged

vendor: github.com/danieljoos/wincred v1.2.0#271
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_wincred

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented May 26, 2023

full diff: danieljoos/wincred@v1.1.2...v1.2.0

  • Calling SyscallN directly when dealing with pointer-pointers to try to address
    "Unexpected (nil, nil) result from wincred.GetGenericCredential".
  • Bumped required Go version to 1.18.
  • Bumped dependency to golang.org/x/sys to version 0.8.0.

@thaJeztah thaJeztah marked this pull request as draft May 26, 2023 00:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ce5629) 55.55% compared to head (069ceb8) 55.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           9        9           
  Lines         666      666           
=======================================
  Hits          370      370           
  Misses        253      253           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

full diff: danieljoos/wincred@v1.1.2...v1.2.0

- Calling SyscallN directly when dealing with pointer-pointers to try to address
  "Unexpected (nil, nil) result from wincred.GetGenericCredential".
- Bumped required Go version to 1.18.
- Bumped dependency to golang.org/x/sys to version 0.8.0.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review May 27, 2023 09:52
@thaJeztah thaJeztah merged commit 11e6d37 into docker:master May 27, 2023
@thaJeztah thaJeztah deleted the bump_wincred branch May 27, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants