Dockerfile: fix vendor validation#253
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jan 30, 2023
Merged
Conversation
Signed-off-by: CrazyMax <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
reviewed
Jan 23, 2023
| FROM vendored AS vendor-validate | ||
| RUN --mount=type=bind,target=.,rw <<EOT | ||
| RUN --mount=target=/context \ | ||
| --mount=target=.,type=tmpfs <<EOT |
Member
There was a problem hiding this comment.
Wondering if we should change all the .'s with an absolute paths (I think it's /src in this case?). Currently I have to read "up" in the Dockerfile to understand what . refers to.
Do we know why a tmpfs is needed for this? Is this an issue with overlayfs not supporting some attributes, or what's the cause?
Member
There was a problem hiding this comment.
Or is there no content at all (as there's no COPY) and that was the issue?
Member
Author
There was a problem hiding this comment.
Or is there no content at all (as there's no
COPY) and that was the issue?
Yes that was the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #252 (comment)
Signed-off-by: CrazyMax [email protected]