Skip to content

Fix build status badge being broken#252

Merged
crazy-max merged 1 commit intodocker:masterfrom
okrc:patch-1
Jan 30, 2023
Merged

Fix build status badge being broken#252
crazy-max merged 1 commit intodocker:masterfrom
okrc:patch-1

Conversation

@okrc
Copy link
Copy Markdown
Contributor

@okrc okrc commented Jan 22, 2023

crazy-max
crazy-max approved these changes Jan 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 22, 2023 •
edited
Loading

Codecov Report

Base: 55.55% // Head: 55.55% // No change to project coverage 👍

Coverage data is based on head (681aeee) compared to base (ac5992b).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           9        9           
  Lines         666      666           
=======================================
  Hits          370      370           
  Misses        253      253           
  Partials       43       43

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crazy-max
Copy link
Copy Markdown
Member

crazy-max commented Jan 22, 2023

https://github.com/docker/docker-credential-helpers/actions/runs/3977887729/jobs/6825115357#step:4:383

 > [vendor-validate 1/1] RUN --mount=type=bind,target=.,rw <<EOT (set -e...):
#0 0.072 rsync: [sender] change_dir "/context" failed: No such file or directory (2)
#17 0.194 rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1333) [sender=3.2.3]

Not related to this change but needs to be fixed in follow-up

@crazy-max crazy-max mentioned this pull request Jan 22, 2023
Merged
@crazy-max crazy-max merged commit d783511 into docker:master Jan 30, 2023
@okrc okrc deleted the patch-1 branch February 1, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okrc @codecov-commenter @crazy-max