Dockerfile: merge build stages#249
Conversation
| make build-osxkeychain build-pass PACKAGE=$PACKAGE VERSION=$(cat /tmp/.version) REVISION=$(cat /tmp/.revision) DESTDIR=/out | ||
| xx-verify /out/docker-credential-osxkeychain | ||
| xx-verify /out/docker-credential-pass | ||
| case "$(xx-info os)" in |
There was a problem hiding this comment.
Isn't this the same as TARGETOS ?
There was a problem hiding this comment.
We use xx-info os because we don't expose ARG TARGETOS but ARG TARGETPLATFORM which already contains the os and xx is able to parse: https://github.com/tonistiigi/xx/blob/aba3b88003b046b8557cdf25959ba0c3c81394c2/base/xx-info#L82
It's just to avoid adding the extra TARGETOS arg if that makes sense.
|
This one needs a rebase; I tried to do so locally (can push); think one of the conflicts is related to; Which probably needs to be added in the |
crazy-max
force-pushed
the
upd-dockerfile
branch
4 times, most recently
from
2813716 to
2edfd6b
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
upd-dockerfile
branch
from
2edfd6b to
ae84c25
Compare
Ah forgot about this one, should be good now |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| xx-verify /out/docker-credential-secretservice | ||
| ;; | ||
| darwin) | ||
| go install std |
There was a problem hiding this comment.
Does this need that other change?
export MACOSX_VERSION_MIN=$(make print-MACOSX_DEPLOYMENT_TARGET)
There was a problem hiding this comment.
oh! never mind you put it further up :see
3 participants
don't need extra stages per target os.
Signed-off-by: CrazyMax [email protected]