Skip to content

secretservice: allow building on openbsd#228

Merged
vvoland merged 1 commit intodocker:mainfrom
thaJeztah:carry_openbsd_secretservice
Apr 20, 2026
Merged

secretservice: allow building on openbsd#228
vvoland merged 1 commit intodocker:mainfrom
thaJeztah:carry_openbsd_secretservice

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

There is nothing linux specific about secretservice. I was able to
build it on openbsd with this change.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 20, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thaJeztah
Copy link
Copy Markdown
Member Author

Yup; already thought this would need some more changes; probably needs to have a _unix.go suffix, and excluded on windows/mac

@thaJeztah thaJeztah marked this pull request as draft April 17, 2026 13:56
@thaJeztah thaJeztah force-pushed the carry_openbsd_secretservice branch from 1249202 to 2b657a2 Compare April 17, 2026 14:00
@thaJeztah thaJeztah marked this pull request as ready for review April 20, 2026 10:16
There is nothing linux specific about secretservice. I was able to
build it on openbsd with this change.

Signed-off-by: Rafael Ávila de Espíndola <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title Enable secretservice on non-linux systems secretservice: allow building on openbsd Apr 20, 2026
@thaJeztah thaJeztah force-pushed the carry_openbsd_secretservice branch from 2b657a2 to 5fcff35 Compare April 20, 2026 10:57
@vvoland vvoland merged commit ca5e83c into docker:main Apr 20, 2026
14 checks passed
@thaJeztah thaJeztah deleted the carry_openbsd_secretservice branch April 20, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants