pass: trim pass show output#108
Merged
vdemeester merged 1 commit intodocker:masterfrom Jun 27, 2018
Hidden character warning
The head ref may contain hidden characters: "pass-trim\u202e\u202e\u202e\u202e\u202e\u202e\u202e\u202etrim-pass"
Merged
Conversation
Contributor
|
LGTM! |
vdemeester
force-pushed
the
pass-trimtrim-pass
branch
from
4ba0c05 to
50d0778
Compare
Collaborator
|
Rebased against master to get CI green 👼 |
As of 8446a40, pass show will include a newline when showing a password. This causes the pass helper here to reliably fail to initialize since a password doesn't round-trip. Before making this change, the pass test would fail if the installed password-store version was v1.7.1+, and after this change it passes again. Fixes docker#107 Signed-off-by: Euan Kemp <[email protected]>
vdemeester
force-pushed
the
pass-trimtrim-pass
branch
from
50d0778 to
dd27c24
Compare
|
Have been facing the same issue. Has the patch been made available as an update? |
|
@raghuvanshy It's in v0.6.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 8446a40, pass show will include a newline when showing a password.
This causes the pass helper here to reliably fail to initialize since a
password doesn't round-trip.
Before making this change, the pass test would fail if the installed
password-store version was v1.7.1+, and after this change it passes
again.
Fixes #107