Skip to content

[20.10 backport] bump Compose version to v2.12.1#775

Closed
glours wants to merge 1 commit into
docker:20.10from
glours:backport-bump-compose-version-2.12.1
Closed

[20.10 backport] bump Compose version to v2.12.1#775
glours wants to merge 1 commit into
docker:20.10from
glours:backport-bump-compose-version-2.12.1

Conversation

@glours

@glours glours commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit a7226ba)
Signed-off-by: Guillaume Lours [email protected]

@glours
bump Compose version to v2.12.1
c0028a5 
Signed-off-by: Guillaume Lours <[email protected]>
(cherry picked from commit a7226ba)
Signed-off-by: Guillaume Lours <[email protected]>
@glours
glours requested a review from thaJeztah October 21, 2022 15:00
@glours glours self-assigned this Oct 21, 2022
StefanScherer
StefanScherer approved these changes Oct 21, 2022
View reviewed changes

@StefanScherer StefanScherer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah changed the title bump Compose version to v2.12.1 [20.10 backport] bump Compose version to v2.12.1 Oct 21, 2022
@thaJeztah

thaJeztah commented Oct 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Ah, dang.. we need to fix something; this won't work with go1.18;

builder/remotecontext/git/gitutils.go:216:23: cmd.Environ undefined (type *exec.Cmd has no field or method Environ)

/go/pkg/mod/github.com/docker/[email protected]+incompatible/builder/remotecontext/git/gitutils.go:216:23: cmd.Environ undefined (type *exec.Cmd has no field or method Environ)
make[2]: *** [Makefile:51: build] Error 2
make[2]: Leaving directory '/root/build-deb/compose'
make[1]: *** [debian/rules:20: override_dh_auto_build] Error 2
make[1]: Leaving directory '/root/build-deb'
make: *** [debian/rules:123: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
Makefile:74: recipe for target 'raspbian-bullseye' failed
make[1]: *** [raspbian-bullseye] Error 2
make[1]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-775/deb'
Makefile:84: recipe for target 'raspbian-bullseye' failed
make: *** [raspbian-bullseye] Error 2
script returned exit code 2

This was referenced Oct 21, 2022
Merged
Merged
Merged
@milas milas mentioned this pull request Oct 21, 2022
Merged
@thaJeztah

thaJeztah commented Oct 22, 2022

Copy link
Copy Markdown
Member

superseded by #777

@thaJeztah thaJeztah closed this Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah Awaiting requested review from thaJeztah
1 more reviewer
@StefanScherer StefanScherer StefanScherer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@glours glours

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glours @thaJeztah @StefanScherer