Defaults Makefile VERSION variable to 0.0.0-dev#67
Merged
Conversation
seemethere
force-pushed
the
fix_makefile_versioning
branch
from
09ad0cb to
315a950
Compare
When building we should default to a dummy version unless otherwise specified so we don't get ourselves confused over what is official and what is not. Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
fix_makefile_versioning
branch
from
315a950 to
17c0d3b
Compare
|
We build our own fork of Docker CE and try to stick to the official released tags, so it's nice to be able to get the actual Of course we can just specify VERSION explicitly when we do so, but it would be nice if we didn't have to :) By the way, thank you so much for the work in this repo. We are finally upgrading from v1.11 and |
glours
pushed a commit
that referenced
this pull request
Mar 23, 2020
When building we should default to a dummy version unless otherwise specified so we don't get ourselves confused over what is official and what is not. Signed-off-by: Eli Uriegas <[email protected]> (cherry picked from commit ffcd040) Signed-off-by: Eli Uriegas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building we should default to a dummy version unless otherwise
specified so we don't get ourselves confused over what is official and
what is not.
Relates to: moby/moby#35368
Thanks to @glasser for first discovering this!
Signed-off-by: Eli Uriegas [email protected]