[DNM] test manpages from docker/cli gha-validate pr #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
test-cli-validate-pr
branch
3 times, most recently
from
519fa99 to
1e9c6e8
Compare
Member
Author
|
On CentOS Jenkins nodes Git is quite old: @thaJeztah Not sure where to update the Dockerfile |
crazy-max
force-pushed
the
test-cli-validate-pr
branch
4 times, most recently
from
7d77711 to
6208a41
Compare
crazy-max
commented
Jan 27, 2022
Comment on lines
+21
to
+39
| # Use recent Git version | ||
| ARG GIT_VERSION="2.30.0" | ||
| RUN yum install -y \ | ||
| curl-devel \ | ||
| expat-devel \ | ||
| gettext-devel \ | ||
| openssl-devel \ | ||
| perl-CPAN \ | ||
| perl-devel \ | ||
| wget \ | ||
| zlib-devel \ | ||
| && yum --setopt=group_package_types=mandatory,default,optional groupinstall -y "Development Tools" \ | ||
| && wget https://github.com/git/git/archive/v${GIT_VERSION}.tar.gz -O git.tar.gz \ | ||
| && tar -zxf git.tar.gz \ | ||
| && cd git-* \ | ||
| && make prefix=/usr/local all \ | ||
| && make prefix=/usr/local install \ | ||
| && rm -rf /git* \ | ||
| && git --version |
Member
Author
There was a problem hiding this comment.
Ok needs to update Git for CentOS 7. I prefer to build from source as some third party repositories are not reliable and trusted. It takes a few minutes to build Git, so I think it's fine.
Member
Author
|
PTAL @thaJeztah about #620 (comment) if you have a better alternative. |
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
test-cli-validate-pr
branch
from
6208a41 to
a745906
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
test-cli-validate-pr
branch
from
a745906 to
2404572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing:
cc @thaJeztah
Signed-off-by: CrazyMax [email protected]