[master] Remove image-based build (for docker engine activate) #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
remove_engine_activate
branch
from
7f8aefb to
19b81f9
Compare
thaJeztah
commented
Dec 5, 2019
| sh("git -C engine checkout $branch") | ||
| sh('make -C deb VERSION=0.0.1-dev ENGINE_DIR=$(pwd)/engine CLI_DIR=$(pwd)/cli ubuntu-xenial') | ||
| } finally { | ||
| sh('make ENGINE_DIR=$(pwd)/engine clean-engine') |
Member
Author
There was a problem hiding this comment.
Wasn't sure if we needed this, but only the image-based build ran clean-engine. Perhaps we should call make -C deb ... clean here as well?
8 tasks
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_engine_activate
branch
from
19b81f9 to
5b8545f
Compare
Member
Author
|
ping @zelahi @andrewhsu @tiborvass PTAL |
Member
Author
|
ping @zelahi @andrewhsu @tiborvass @silvin-lubecki PTAL |
Member
Author
|
bringing this one in to unblock other PRs |
This was referenced Jan 21, 2020
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to docker/cli#2207
related to #416
closes #417