Make standalone SSE usage in mcp tools configurable#3770
Merged
Conversation
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The PR cleanly introduces a configurable standaloneSSE flag on remoteMCPClient and exposes it through Toolset.SetStandaloneSSE. The implementation is correct:
c.muissync.RWMutex(embedded fromsessionClient), soc.mu.RLock()/c.mu.RUnlock()inInitializecompiles correctly and is consistent with existing usage throughoutsession_client.go.- The type assertion on
ts.mcpClientinToolset.SetStandaloneSSEwithout holdingts.muis safe —mcpClientis set in the constructor and never reassigned, matching the same pattern already used inKind()andWorkingDir(). SetStandaloneSSEuses a write lock (c.mu.Lock()) whileInitializeuses a read lock to snapshot the field — correct reader/writer separation.- Defaulting to
false(standalone SSE disabled) preserves backward compatibility.
rumpl
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow library users to configure if they want standalone sse enabled or not
Defaults to false to not introduce a potentially breaking change