feat: support Mermaid state diagram directions#3764
Merged
Conversation
Signed-off-by: Djordje Lukic <[email protected]>
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
No bugs introduced by this PR. The direction-parsing logic and render path change are correct:
- The
directionkeyword branch inparseStatealways executescontinue— the only potentially affected syntax (state direction as Foo) uses an unquoted label, which the existingstatebranch would reject viareadQuoted()anyway, so no valid statement is dropped. - Switching
DiagramStatefromdrawMermaidGraphtodrawMermaidFlowchartwith an empty direction string safely falls through to the samedrawMermaidGraphcall with identical arguments — no behavioural regression for undirected state diagrams.
rumpl
enabled auto-merge
July 20, 2026 21:30
dgageot
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.