Skip to content

feat: support Mermaid state diagram directions#3764

Merged
rumpl merged 1 commit into
docker:mainfrom
rumpl:feat/mermaid-state-directions
Jul 21, 2026
Merged

feat: support Mermaid state diagram directions#3764
rumpl merged 1 commit into
docker:mainfrom
rumpl:feat/mermaid-state-directions

Conversation

@rumpl

@rumpl rumpl commented Jul 20, 2026

Copy link
Copy Markdown
Member

No description provided.

@rumpl
rumpl requested a review from a team as a code owner July 20, 2026 21:22

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

No bugs introduced by this PR. The direction-parsing logic and render path change are correct:

  • The direction keyword branch in parseState always executes continue — the only potentially affected syntax (state direction as Foo) uses an unquoted label, which the existing state branch would reject via readQuoted() anyway, so no valid statement is dropped.
  • Switching DiagramState from drawMermaidGraph to drawMermaidFlowchart with an empty direction string safely falls through to the same drawMermaidGraph call with identical arguments — no behavioural regression for undirected state diagrams.

@rumpl
rumpl enabled auto-merge July 20, 2026 21:30
@aheritier aheritier added area/tui For features/issues/fixes related to the TUI kind/feat PR adds a new feature (maps to feat:). Use on PRs only. status/ready-for-review Ready for implementation, design review, or final review labels Jul 20, 2026
@rumpl
rumpl merged commit cecf9f8 into docker:main Jul 21, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tui For features/issues/fixes related to the TUI kind/feat PR adds a new feature (maps to feat:). Use on PRs only. status/ready-for-review Ready for implementation, design review, or final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants