Mermaid flowchart directions#3715
Merged
Merged
Conversation
Signed-off-by: Djordje Lukic <[email protected]>
Signed-off-by: Djordje Lukic <[email protected]>
Signed-off-by: Djordje Lukic <[email protected]>
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR cleanly adds horizontal (LR/RL) and vertical (BT) flowchart direction support to the Mermaid TUI renderer, replacing go-runewidth with github.com/charmbracelet/x/ansi for proper grapheme-cluster-aware width calculations, and polishing box-drawing characters with rounded corners. The implementation is consistent and well-structured. One minor rendering edge case was identified in the new RL flip path.
Signed-off-by: Djordje Lukic <[email protected]>
rumpl
force-pushed
the
feat/mermaid-flowchart-directions
branch
from
July 17, 2026 10:20
d84d233 to
f46b5b0
Compare
rumpl
enabled auto-merge
July 17, 2026 10:25
Sayt-0
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And as a bonus a nicer, rounder rendering