feat(tui): extend session browser search to match session IDs#3708
Conversation
Assisted-By: docker-agent
aheritier
added
area/tui
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The ID-matching logic is correct and the implementation is clean. One minor edge case worth considering: a query consisting entirely of dashes (e.g. ---) reduces to an empty idQuery after stripping, so the ID path never matches, and the title path also never matches, leaving the user with an empty results list. See the inline comment for details.
| func (d *sessionBrowserDialog) filterSessions() { | ||
| query := strings.ToLower(strings.TrimSpace(d.textInput.Value())) | ||
| // IDs are matched with dashes stripped so partial UUIDs paste-match. | ||
| idQuery := strings.ReplaceAll(query, "-", "") |
There was a problem hiding this comment.
[low] Dash-only query filters out all sessions instead of showing all
When a user types a string composed entirely of dashes (e.g. ---), query is non-empty ("---"), so the if query != "" guard fires and filtering is applied. However, idQuery becomes "" after dash-stripping, making matchesSessionID return false. Normal session titles do not contain "---" either, so every session is filtered out and the user sees an empty list.
A user who pastes or types --- might reasonably expect all sessions to appear (as if the query were empty), but instead gets zero results with no feedback. The test suite does not cover this edge case.
One way to address it: after computing idQuery, if it is empty reset query to "" so the loop treats the input as no-op filtering:
idQuery := strings.ReplaceAll(query, "-", "")
if idQuery == "" {
query = ""
}This keeps both the title path and the ID path consistent with the intent that a "blank" query (or one that reduces to blank) shows all sessions.
| Confidence | Score |
|---|---|
| 🟡 moderate | 75/100 |
4 participants
The
/sessionsbrowser search filter previously matched only session titles. Users who copy a session ID (e.g. fromctrl+yor a log) and paste it into the search box got no results, which made it hard to jump back to a known session.This change extends
filterSessionsso that a query also matches against the session ID, case-insensitively and with-characters stripped on both sides. That means full UUIDs, dash-less variants, and partial fragments — however the user pastes or types them — all resolve to the right session. Title matching is completely unchanged.A new test
TestSessionBrowserSearchByIDcovers full-ID, dash-less, partial-with-dashes, partial-without-dashes, case-insensitive, title-fallback, and no-match cases.