fix(server): surface background elicitations over API#3678
Merged
Conversation
aheritier
marked this pull request as draft
July 16, 2026 10:35
aheritier
added
area/api
Contributor
|
👋 This PR has merge conflicts with the base branch. Please rebase or merge the latest base branch and resolve them. I've moved it to draft and added |
…round-elicitations # Conflicts: # docs/features/api-server/index.md # pkg/server/session_manager.go # pkg/server/session_manager_test.go
Sayt-0
marked this pull request as ready for review
July 16, 2026 10:50
dgageot
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the server/API portion of #3584 so elicitation requests raised by concurrent background jobs are replayable and answerable instead of being auto-declined when no per-request stream is active.
This supersedes #3625 with the same core session-scoped sink plus the lifecycle and concurrency hardening found during review.
Issue expectations
/eventslogelicitation_idis preserved throughPOST /api/sessions/:id/elicitationRunStreamcopies are skipped when the reliable sink already delivered the eventImplementation
OnElicitationRequestsink for API/server-created runtimes.RunStream.Validation
go test ./...go test -race ./pkg/server ./pkg/runtime/...go build ./...go vet ./pkg/server/... ./pkg/runtime/...golangci-lint run ./pkg/server/... ./pkg/runtime/...markdownlint-cli2 docs/features/api-server/index.mdAll checks pass. The full test suite was run with workspace proxy variables unset because the injected proxy intercepts the private-address SSRF tests.
Closes #3584