test(eval): cover container interruption on cancellation#3649
Merged
Conversation
Sayt-0
enabled auto-merge
July 15, 2026 09:50
aheritier
added
area/testing
dgageot
approved these changes
Jul 15, 2026
aheritier
approved these changes
Jul 15, 2026
Sayt-0
force-pushed
the
test/3585-eval-cancellation-signal
branch
from
July 15, 2026 11:29
3dd3212 to
52b7640
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add daemon-free regression coverage for the eval container cancellation fix introduced in #3615.
The test replaces
dockerwith a helper process, cancels an in-flight evaluation, and verifies that the Docker CLI receivesSIGINTand exits promptly. This protects against reverting toexec.CommandContext's defaultSIGKILLbehavior, which cannot be proxied to the container and can leave--rmeval containers running.Issue expectations
WaitDelaybackstopdockerexecutablecmd.Cancelcauses the test to fail withsignal: killedValidation
task buildtask testtask lintgo vet ./pkg/evaluationThe full test suite was run without the sandbox-injected HTTP proxy because that proxy intercepts private-address SSRF fixtures.
Closes #3585