Improve the command categories#3523
Merged
Merged
Conversation
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
docker-agent
reviewed
Jul 8, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR cleanly reorganizes command categories by introducing a new diagnose group and reassigning commands to better-fitting groups. All GroupID values (core, diagnose, advanced) are properly registered via AddGroup in root.go, so no orphaned or missing group references are introduced. The group registration order (core → diagnose → advanced) produces a sensible help layout. Removing the agentcatalog/pirate example is cosmetic and introduces no functional issue.
No bugs found.
aheritier
added
area/cli
Sayt-0
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot [email protected]