Skip to content

fix(board): clarify dirty-worktree removal prompt with explicit consequences#3520

Merged
dgageot merged 2 commits into
docker:mainfrom
dgageot:worktree-board-f60e5abcf674afad
Jul 8, 2026
Merged

fix(board): clarify dirty-worktree removal prompt with explicit consequences#3520
dgageot merged 2 commits into
docker:mainfrom
dgageot:worktree-board-f60e5abcf674afad

Conversation

@dgageot

@dgageot dgageot commented Jul 8, 2026

Copy link
Copy Markdown
Member

When a card's worktree has uncommitted changes or unpushed commits and the user
tries to close the card, docker-agent asks whether to delete it. The old prompt
crammed the question and the explanation into a single line, making it unclear
what "y" and "N" would actually do. Users had to parse a single run-on sentence
to understand that "y" meant permanent deletion.

The prompt now prints the two options on separate indented lines before asking
the question, so the consequences of each choice are unambiguous at a glance.
The question itself is moved to the last line using Print instead of
Println, which leaves the cursor right after the (y/N) marker — consistent
with how every other interactive prompt in the CLI behaves.

No behavioural change; the logic that reads and acts on the response is
untouched.

@dgageot
dgageot requested a review from a team as a code owner July 8, 2026 06:24

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

Clean, focused prompt reformatting. The switch from Println to Print for the question line is correct — the trailing space keeps the cursor inline for the ReadLine call, consistent with other interactive prompts in the CLI. The two new indented option lines make the consequences of each choice unambiguous. No behavioural change, no bugs introduced.

@aheritier aheritier added area/cli CLI commands, flags, output formatting kind/fix PR fixes a bug (maps to fix:). Use on PRs only. labels Jul 8, 2026
@dgageot
dgageot merged commit 1e94365 into docker:main Jul 8, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli CLI commands, flags, output formatting kind/fix PR fixes a bug (maps to fix:). Use on PRs only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants