Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Add changelog for containerd v1.4.4-1#223

Merged
tiborvass merged 1 commit into
docker:masterfrom
fuweid:update-changelog-1.4.4
Mar 8, 2021
Merged

Add changelog for containerd v1.4.4-1#223
tiborvass merged 1 commit into
docker:masterfrom
fuweid:update-changelog-1.4.4

Conversation

@fuweid

@fuweid fuweid commented Mar 8, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Wei Fu [email protected]

@fuweid

fuweid commented Mar 8, 2021

Copy link
Copy Markdown
Contributor Author

ping @thaJeztah @tonistiigi @tiborvass ptal thanks~

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Had this one on my list for today, so this saves me some work 😅; left one comment

Comment thread debian/changelog Outdated
@fuweid
fuweid force-pushed the update-changelog-1.4.4 branch from f7ba1d1 to 2280625 Compare March 8, 2021 08:12

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah

Copy link
Copy Markdown
Member

Hmm.. I notice that #221 was also merged, but looks like packages were not (yet) pushed to download.docker.com; I'll check with @tiborvass if that was intentional (and if we'll skip that version, or push both);

$ apt-cache madison containerd.io | head -n4
containerd.io |    1.4.3-1 | https://download.docker.com/linux/ubuntu bionic/stable amd64 Packages
containerd.io |    1.3.9-1 | https://download.docker.com/linux/ubuntu bionic/stable amd64 Packages
containerd.io |    1.3.7-1 | https://download.docker.com/linux/ubuntu bionic/stable amd64 Packages
containerd.io |   1.2.13-2 | https://download.docker.com/linux/ubuntu bionic/stable amd64 Packages

I suspect that relates to #222 (review)

@fuweid

fuweid commented Mar 8, 2021

Copy link
Copy Markdown
Contributor Author

#221

just FYI, containerd doesn't mention runc-rc93 in vendor.conf 😂

@thaJeztah

Copy link
Copy Markdown
Member

just FYI, containerd doesn't mention runc-rc93 in vendor.conf 😂

Yes, so there's two things currently; current code in this repo was not yet adjusted for the switch to go.mod in upstream (had that one on my list; just pushed a fix, but looks like I need to modify somethings; #224)

Reason we were already moving to runc-rc93 (slightly ahead of upstream containerd) is that there were too many issues related to seccomp when using images with recent ubuntu versions as base image. Runc rc93 has this patch opencontainers/runc#2750, which helps for those situations; we know some cloud providers also started to install runc rc93 (and some distros started to patch their packages to update to that version as well);

@tiborvass
tiborvass merged commit bef5ad7 into docker:master Mar 8, 2021
@fuweid
fuweid deleted the update-changelog-1.4.4 branch March 9, 2021 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants