Jenkins parameters belong to Jenkinsfile#222
Conversation
For some unknown reasons there are Jenkins parameters that are neither defined in Jenkins nor in Jenkinsfile. ARCHIVE and CONTAINERD_REF were taken from the output of: https://ci-next.docker.com/teams-core/job/containerd-packaging/job/master/configure while RUNC_REF was added so we can build a version different from the vendored one in containerd. Signed-off-by: Tibor Vass <[email protected]>
cc6e798 to
8c249ea
Compare
StefanScherer
left a comment
StefanScherer
left a comment
There was a problem hiding this comment.
Makes sense to put this into code! 🎉
LGTM
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
For some unknown reasons there are Jenkins parameters that are neither defined in Jenkins nor in Jenkinsfile.
@tiborvass I think these were not in this Jenkinsfile because the Jenkinsfile in this CI is only used to build "tip".
The Jenkinsfile in our release pipeline has the options to pass what versions to build from when we do a package release; https://github.com/docker/release-packaging/blob/containerd/Jenkinsfile#L96-L104
(copying the snippet here, as it's in a private repo);
parameters {
string(name: 'CONTAINERD_REF', defaultValue: 'v1.4.2', description: 'containerd reference to build (usually a tagged version)')
string(name: 'CONTAINERD_REMOTE', defaultValue: '[email protected]:containerd/containerd', description: 'repo containing containerd source code')
string(name: 'PACKAGING_REF', defaultValue: 'master', description: 'release-packaging reference to build')
string(name: 'PACKAGING_REMOTE', defaultValue: '[email protected]:docker/containerd-packaging', description: 'repo containing code to package containerd')
string(name: 'GO_VERSION', defaultValue: '1.13.15', description: 'Go version to use to build')
}Looking at that, I think we need to update that Jenkinsfile to allow overriding RUNC_REF (which, so far, we didn't do)
| [ | ||
| booleanParam(name: 'ARCHIVE', defaultValue: false, description: 'Archive the build artifacts by pushing to an S3 bucket.'), | ||
| string(name: 'CONTAINERD_REF', defaultValue: 'master', description: 'Git ref of containerd repo to build.'), | ||
| string(name: 'RUNC_REF', defaultValue: '', description: 'Git ref of runc repo to build.'), |
There was a problem hiding this comment.
Will this cause the default "automatic selection from upstream" to be skipped?
containerd-packaging/common/common.mk
Lines 27 to 31 in 484fe7c
| [ | ||
| parameters( | ||
| [ | ||
| booleanParam(name: 'ARCHIVE', defaultValue: false, description: 'Archive the build artifacts by pushing to an S3 bucket.'), |
There was a problem hiding this comment.
Is this used anywhere in this repository? I know we have CREATE_ARCHIVE, but that's not related to pushing to s3;
containerd-packaging/Jenkinsfile
Line 52 in 8c249ea
(Couldn't find a reference to this parameter in our internal release repo either)
3 participants
For some unknown reasons there are Jenkins parameters that are neither defined in Jenkins nor in Jenkinsfile.
ARCHIVE and CONTAINERD_REF were taken from the output of:
https://ci-next.docker.com/teams-core/job/containerd-packaging/job/master/configure
while RUNC_REF was added so we can build a version different from the vendored one in containerd.
Signed-off-by: Tibor Vass [email protected]