go.mod: docker 5aac513617f072b15322b147052cbda0d451d389 / v22.06-dev#9940
Conversation
This restores compatibility with go1.18, which was broken since commit; moby/moby@c062238 cmd.Environ() is new in go1.19, and not needed for this specific case. Without this, trying to use this package in code that uses go1.18 will fail; builder/remotecontext/git/gitutils.go:216:23: cmd.Environ undefined (type *exec.Cmd has no field or method Environ) Changing to use `os.Environ()` instead restores compatibility with go1.18 Full diff: moby/moby@f9cb47a...5aac513 Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
@milas @StefanScherer @glours PTAL 🤗 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #9940 +/- ##
=======================================
Coverage 74.56% 74.56%
=======================================
Files 2 2
Lines 232 232
=======================================
Hits 173 173
Misses 51 51
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
I'll bring this one in, so that it's the first commit after v2.12.1, keeping our options open 👍 |
|
FWIW we maintain compatibility with (Agreed that having the change available is good though, thanks for making the updates here) |
|
@milas yeah, so in this case, it was because compose depends on (not yet released) v22.06 code (through buildx). v22.06 is intended for go1.19 and above, but the current 20.10 release is still on go1.18. The release pipeline uses that version of go to build the binaries (which currently does not allow for differentiation go versions for each individual binary), causing the build to fail; docker/docker-ce-packaging#775 Perhaps we can add some hacks to install multiple go versions in the container build environment (and some |
|
Ah right, |
|
I know.. I know. Having all tied together.. complicate "things". |
4 participants
This restores compatibility with go1.18, which was broken since commit; moby/moby@c062238
cmd.Environ() is new in go1.19, and not needed for this specific case. Without this, trying to use this package in code that uses go1.18 will fail;
Changing to use
os.Environ()instead restores compatibility with go1.18Full diff: moby/moby@f9cb47a...5aac513
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did