Skip to content

bump compose-go to 1.2.6#9495

Merged
glours merged 1 commit into
docker:v2from
maxcleme:chore/bump_compose_go
May 23, 2022
Merged

bump compose-go to 1.2.6#9495
glours merged 1 commit into
docker:v2from
maxcleme:chore/bump_compose_go

Conversation

@maxcleme
Copy link
Copy Markdown
Member

Signed-off-by: Maxime CLEMENT [email protected]

What I did

Bump compose-go to 1.2.6 to integrate latest fix :

Related issue

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Signed-off-by: Maxime CLEMENT <[email protected]>
@maxcleme maxcleme requested a review from glours May 23, 2022 12:52
Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhavajay
Copy link
Copy Markdown

Does anyone know when this will hit Docker Desktop? This broke our environment for everyone on Monday and cost us a few hours of debugging and forcing a lot of uninstalls and re-installs of old versions.

@maxcleme
Copy link
Copy Markdown
Member Author

@madhavajay We are working on extensive test suite to be added as long with the fix on the next release.

@madhavajay
Copy link
Copy Markdown

@maxcleme any chance of a quick point release for Docker Desktop because this breaks docker compose v2 for a lot of people and the new Upgrade policy for docker is very aggressive meaning that most people are being pushed to the new version rapidly, I would prefer not to have to explain to all our customers, devs and users that they need to uninstall docker, go back to some old version etc.

@maxcleme
Copy link
Copy Markdown
Member Author

@madhavajay You can look at current progress for the test suite here. I don't have more visibility for upcoming release, but I would assume a release might be done once the test suite is finished/merged.

@madhavajay
Copy link
Copy Markdown

@maxcleme thanks, although surely since this is a regression it would be worth releasing a docker desktop without compose 2.5.1 and yanking it instead or just yanking the new docker desktop version? I suspect we may have to update our code by early next week just in case. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants