now we use directly the Docker CLI to run autoremove flag should be p…#9342
Merged
Conversation
…ass as is Signed-off-by: Guillaume Lours <[email protected]>
thaJeztah
reviewed
Apr 1, 2022
| updateServices(&service, observedState) | ||
|
|
||
| created, err := s.createContainer(ctx, project, service, service.ContainerName, 1, | ||
| opts.Detach && opts.AutoRemove, opts.UseNetworkAliases, opts.Interactive) |
Member
There was a problem hiding this comment.
Was this because there was some code on the compose side to handle this case? (that has been removed?)
Just double-checking if there's not also code on compose's side, causing a potential race on "who gets to remove it first" 😂
Contributor
Author
There was a problem hiding this comment.
Yep it was, previously the remove part was done by Compose, see here
func (s *composeService) terminateRun(ctx context.Context, containerID string, opts api.RunOptions) (exitCode int, err error) {
exitCh, errCh := s.apiClient().ContainerWait(ctx, containerID, container.WaitConditionNotRunning)
select {
case exit := <-exitCh:
exitCode = int(exit.StatusCode)
case err = <-errCh:
return
}
if opts.AutoRemove {
err = s.apiClient().ContainerRemove(ctx, containerID, moby.ContainerRemoveOptions{})
}
return
}
Member
There was a problem hiding this comment.
Ah, great! Thanks for confirming 👍
ndeloof
approved these changes
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ass as is
What I did
Pass the
rmflag value as is to the Docker CLI when running a container with this flagfix #9314
(not mandatory) A picture of a cute animal, if possible in relation with what you did
