Merge and fix Convert function from docker/compose-switch#8985
Merged
Merge and fix Convert function from docker/compose-switch#8985
docker/compose-switch#8985Conversation
ulyssessouza
commented
Dec 2, 2021
ulyssessouza
force-pushed
the
fix-on-docker-root-flags
branch
2 times, most recently
from
2f4583f to
e670dcb
Compare
Contributor
ndeloof
requested changes
Dec 2, 2021
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
removal of the compose pre-command breaks standalone usage.
Contributor
Author
|
@ndeloof Ops... Sorry. My environment was just restarted after the update of DD. I was testing with one thinking it was the other... |
ulyssessouza
force-pushed
the
fix-on-docker-root-flags
branch
2 times, most recently
from
6d31e24 to
05a7114
Compare
Contributor
Author
|
@ndeloof PTAL |
mat007
reviewed
Dec 3, 2021
Member
mat007
left a comment
mat007
left a comment
There was a problem hiding this comment.
So should we revert the --compatibility flag from compose-switch after merging this?
ulyssessouza
force-pushed
the
fix-on-docker-root-flags
branch
from
05a7114 to
9d67f34
Compare
Member
Ah actually that PR doesn’t add that flag here, for some reason I thought it did, based on whether we detected if we’re running standalone or not… Never mind, ignore me 😬 |
ulyssessouza
force-pushed
the
fix-on-docker-root-flags
branch
from
9d67f34 to
f8b4727
Compare
This also removes the vendoring of the repo Note that it fixes the problem of double "compose" on calling the compose plugin with "docker" root flags. Like in "docker --context default compose version" Signed-off-by: Ulysses Souza <[email protected]>
ulyssessouza
force-pushed
the
fix-on-docker-root-flags
branch
from
f8b4727 to
9306f4d
Compare
ndeloof
approved these changes
Dec 3, 2021
|
|
||
| func convert(args []string) []string { | ||
| var rootFlags []string | ||
| command := []string{compose.PluginName} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Note that it fixes the problem of double "compose" on calling the compose plugin with "docker" root flags.
Like in "docker --context default compose version"
This also removes the vendoring of the repo
Related issue
Resolves #8945