Skip to content

Fix network_mode "service:x"#8792

Merged
ulyssessouza merged 1 commit intodocker:v2from
ulyssessouza:fix-network-mode-service
Oct 20, 2021
Merged

Fix network_mode "service:x"#8792
ulyssessouza merged 1 commit intodocker:v2from
ulyssessouza:fix-network-mode-service

Conversation

@ulyssessouza
Copy link
Copy Markdown
Contributor

Related issue
Resolve #8766

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Copy link
Copy Markdown
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test we can add? 😁

Comment thread pkg/compose/convergence.go
Comment thread pkg/compose/convergence.go Outdated
@ulyssessouza ulyssessouza force-pushed the fix-network-mode-service branch 2 times, most recently from 4da9062 to 3a7c2c2 Compare October 14, 2021 08:20
Signed-off-by: Ulysses Souza <[email protected]>
@ulyssessouza ulyssessouza force-pushed the fix-network-mode-service branch from 3a7c2c2 to c2dd40c Compare October 14, 2021 08:40
Copy link
Copy Markdown
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to run service with network_mode "service:NAME"

2 participants