Add bash completion for profiles and a command to list profiles#8061
Merged
Conversation
albers
force-pushed
the
completion-profiles
branch
4 times, most recently
from
January 22, 2021 17:10
b7ff7d8 to
b900158
Compare
For command completion of `docker-compose --profile`, we need a portable way to get a list of profiles used in the current config. This commit adds a new option `docker-compose config --profiles`. Signed-off-by: Harald Albers <[email protected]>
Signed-off-by: Harald Albers <[email protected]>
albers
force-pushed
the
completion-profiles
branch
from
January 22, 2021 19:25
b900158 to
4e382b9
Compare
albers
changed the title
albers
marked this pull request as ready for review
January 22, 2021 20:07
albers
requested review from
aiordache,
ndeloof,
rumpl and
ulyssessouza
as code owners
January 22, 2021 20:07
Member
|
@aiordache @ulyssessouza ptal |
aiordache
approved these changes
Feb 25, 2021
albers
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bash completion for
docker-compose --profile, which was added in #7930.In order to complete valid profiles, we need a portable way to get a list of profiles used in the current config.
For that purpose, a new option
docker-compose config --profileswas added.It works like the
--servicesand--volumesoptions.I'm new to python development, so I guess there's a more elegant idiom for collecting the profiles.
I appreciate any help here.