Only attach services we're going to read logs from in "up"#8005
Merged
ulyssessouza merged 1 commit intodocker:masterfrom Jan 4, 2021
Merged
Conversation
When 'up' is run with explicit list of services, compose will start them together with their dependencies. It will attach to all started services, but won't read output from dependencies (their logs are not printed by 'up') - so the receive buffer of dependencies will fill and at some point will start blocking those services. Fix that by only attaching to services given in the list. To do that, move logic of choosing which services to attach from cli/main.py to utils.py and use it from project.py to decide if service should be attached. Fixes docker#6018 Signed-off-by: Daniil Sigalov <[email protected]>
asterite3
requested review from
aiordache,
ndeloof,
rumpl and
ulyssessouza
as code owners
ndeloof
approved these changes
Jan 4, 2021
aiordache
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 'up' is run with explicit list of services, compose will start them together with their dependencies. It won't print output from dependencies, but, as discovered by @nthuemmel in #6018, it will still attach to them - without reading their output after that - so the receive buffer for dependencies will fill and at some point will start blocking those services. Fix that by only attaching to services given in the list.
Resolves #6018