Pull latest tag by default#716
Merged
dnephin merged 1 commit intodocker:masterfrom Dec 11, 2014
Merged
Conversation
Author
|
Prompted by running out of disk space. Docker's standard library is enormous now. |
There was a problem hiding this comment.
This _get_container_create_options() is already doing a lot of work unrelated to creating the image name with a tag (none of which is used by pull()). Maybe this could be a new function get_image_name(), called from both pull and _get_container_create_options ?
bfirsh
force-pushed
the
pull-latest-tag-by-default
branch
from
c353ab1 to
309c4b1
Compare
Author
|
@dnephin Pushed updated version with |
bfirsh
force-pushed
the
pull-latest-tag-by-default
branch
from
309c4b1 to
f75d5c3
Compare
There was a problem hiding this comment.
This return seems out of place, shouldn't it still return the container_options ?
This was changed in Docker recently: moby/moby#7759 This means we aren't pulling loads of tags when we only use the latest. Signed-off-by: Ben Firshman <[email protected]>
bfirsh
force-pushed
the
pull-latest-tag-by-default
branch
from
f75d5c3 to
8ebec9a
Compare
|
LGTM! |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Pull latest tag by default Signed-off-by: Yuval Kohavi <[email protected]>
infraAnchor
pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
Co-authored-by: Gavin Kelly <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was changed in Docker recently:
moby/moby#7759
This means we aren't pulling loads of tags when we only use the
latest.
Signed-off-by: Ben Firshman [email protected]